netdev - Re: [PATCH net-next 02/13] netlink: specs: rt-route: specify fixed-header at operations level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d79c0aa-0e48-40f9-93eb-7bf3a0f4c1af@intel.com>
Date: Tue, 8 Apr 2025 21:50:02 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<yuyanghuang@...gle.com>, <sdf@...ichev.me>, <gnault@...hat.com>,
	<nicolas.dichtel@...nd.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next 02/13] netlink: specs: rt-route: specify
 fixed-header at operations level



On 4/8/2025 5:03 PM, Jakub Kicinski wrote:
> The C codegen currently stores the fixed-header as part of family
> info, so it only supports one fixed-header type per spec. Luckily
> all rtm route message have the same fixed header so just move it up
> to the higher level.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  Documentation/netlink/specs/rt-route.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/rt-route.yaml b/Documentation/netlink/specs/rt-route.yaml
> index 292469c7d4b9..6fa3fa24305e 100644
> --- a/Documentation/netlink/specs/rt-route.yaml
> +++ b/Documentation/netlink/specs/rt-route.yaml
> @@ -245,12 +245,12 @@ protonum: 0
>  
>  operations:
>    enum-model: directional
> +  fixed-header: rtmsg
>    list:
>      -
>        name: getroute
>        doc: Dump route information.
>        attribute-set: route-attrs
> -      fixed-header: rtmsg
>        do:
>          request:
>            value: 26

Nice. This seems simpler.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>