netdev - Re: [PATCH v9 1/7] mfd: Add core driver for Nuvoton NCT6694

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14782b0e-3890-4d11-9a40-658da0951dfc@kernel.org>
Date: Thu, 10 Apr 2025 09:55:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: a0282524688@...il.com, linus.walleij@...aro.org, brgl@...ev.pl,
 andi.shyti@...nel.org, mkl@...gutronix.de, mailhol.vincent@...adoo.fr,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, wim@...ux-watchdog.org,
 linux@...ck-us.net, jdelvare@...e.com, alexandre.belloni@...tlin.com,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-usb@...r.kernel.org, Ming Yu <tmyu0@...oton.com>
Subject: Re: [PATCH v9 1/7] mfd: Add core driver for Nuvoton NCT6694

On 10/04/2025 09:52, Lee Jones wrote:
> On Thu, 10 Apr 2025, Krzysztof Kozlowski wrote:
> 
>> On 09/04/2025 10:27, a0282524688@...il.com wrote:
>>> +
>>> +static int nct6694_response_err_handling(struct nct6694 *nct6694,
>>> +					 unsigned char err_status)
>>> +{
>>> +	switch (err_status) {
>>> +	case NCT6694_NO_ERROR:
>>> +		return 0;
>>> +	case NCT6694_NOT_SUPPORT_ERROR:
>>> +		dev_err(nct6694->dev, "Command is not supported!\n");
>>> +		break;
>>> +	case NCT6694_NO_RESPONSE_ERROR:
>>> +		dev_warn(nct6694->dev, "Command received no response!\n");
>>> +		break;
>>> +	case NCT6694_TIMEOUT_ERROR:
>>> +		dev_warn(nct6694->dev, "Command timed out!\n");
>>> +		break;
>>> +	case NCT6694_PENDING:
>>> +		dev_err(nct6694->dev, "Command is pending!\n");
>>> +		break;
>>> +	default:
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	return -EIO;
>>> +}
>>> +
>>
>> Missing Kconfig. Exported functions are supposed to have it.
>           -------
> 
> KernelDoc


Yes, thank you. -ENOCOFFEE


Best regards,
Krzysztof