netdev - Re: [PATCH v9 7/7] rtc: Add Nuvoton NCT6694 RTC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e369a368-6729-4f67-9bb0-28bfd833356f@kernel.org>
Date: Thu, 10 Apr 2025 09:58:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: a0282524688@...il.com, lee@...nel.org, linus.walleij@...aro.org,
 brgl@...ev.pl, andi.shyti@...nel.org, mkl@...gutronix.de,
 mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com,
 alexandre.belloni@...tlin.com
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-usb@...r.kernel.org, Ming Yu <tmyu0@...oton.com>
Subject: Re: [PATCH v9 7/7] rtc: Add Nuvoton NCT6694 RTC support

On 09/04/2025 10:27, a0282524688@...il.com wrote:
> +	data->irq = irq;
> +	data->nct6694 = nct6694;
> +	data->rtc->ops = &nct6694_rtc_ops;
> +	data->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
> +	data->rtc->range_max = RTC_TIMESTAMP_END_2099;
> +
> +	platform_set_drvdata(pdev, data);
> +
> +	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> +					nct6694_irq, IRQF_ONESHOT,
> +					"rtc-nct6694", data);
> +	if (ret < 0) {
> +		dev_err_probe(&pdev->dev, ret, "Failed to request irq\n");
> +		goto dispose_irq;
> +	}
> +
> +	ret = devm_rtc_register_device(data->rtc);
> +	if (ret)
> +		goto dispose_irq;
> +
> +	device_init_wakeup(&pdev->dev, true);

devm_device_init_wakeup

Let's save us from one more patch...

As pointed out in other patch by Bartosz, you have messed cleanups. Use
only devm, because currently your cleanup looks like this:
1. dispose mapping
2. free IRQ

and this should be reversed.

Best regards,
Krzysztof