netdev - Re: [EXTERNAL] Re: [PATCH rdma-next 3/3] RDMA/mana_ib: Add support of 4M, 1G, and 2G pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410135504.GU199604@unreal>
Date: Thu, 10 Apr 2025 16:55:04 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Konstantin Taranov <kotaranov@...rosoft.com>
Cc: Konstantin Taranov <kotaranov@...ux.microsoft.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Dexuan Cui <decui@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>,
	Long Li <longli@...rosoft.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH rdma-next 3/3] RDMA/mana_ib: Add support
 of 4M, 1G, and 2G pages

On Thu, Apr 10, 2025 at 01:38:39PM +0000, Konstantin Taranov wrote:
> > 
> > >  enum gdma_page_type {
> > >  	GDMA_PAGE_TYPE_4K,
> > > +	GDMA_PAGE_SIZE_8K,
> > > +	GDMA_PAGE_SIZE_16K,
> > > +	GDMA_PAGE_SIZE_32K,
> > > +	GDMA_PAGE_SIZE_64K,
> > > +	GDMA_PAGE_SIZE_128K,
> > > +	GDMA_PAGE_SIZE_256K,
> > > +	GDMA_PAGE_SIZE_512K,
> > > +	GDMA_PAGE_SIZE_1M,
> > > +	GDMA_PAGE_SIZE_2M,
> > > +	/* Only when
> > GDMA_DRV_CAP_FLAG_1_GDMA_PAGES_4MB_1GB_2GB is set */
> > > +	GDMA_PAGE_SIZE_4M,
> > > +	GDMA_PAGE_SIZE_1G = 18,
> > > +	GDMA_PAGE_SIZE_2G
> > 
> > Where are all these defines used?
> 
> There are not used explicitly in this patch, but they can be used in theory.

Yes, please.

> I can remove unused defines in V2.
> 
> > 
> > Thanks