netdev - Re: [EXTERNAL] Re: [PATCH rdma-next 1/3] RDMA/mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410135434.GT199604@unreal>
Date: Thu, 10 Apr 2025 16:54:34 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Konstantin Taranov <kotaranov@...rosoft.com>
Cc: Konstantin Taranov <kotaranov@...ux.microsoft.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Dexuan Cui <decui@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>,
	Long Li <longli@...rosoft.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH rdma-next 1/3] RDMA/mana_ib: Access remote
 atomic for MRs

On Thu, Apr 10, 2025 at 01:37:00PM +0000, Konstantin Taranov wrote:
> > > @@ -24,6 +24,9 @@ mana_ib_verbs_to_gdma_access_flags(int
> > access_flags)
> > >  	if (access_flags & IB_ACCESS_REMOTE_READ)
> > >  		flags |= GDMA_ACCESS_FLAG_REMOTE_READ;
> > >
> > > +	if (access_flags & IB_ACCESS_REMOTE_ATOMIC)
> > > +		flags |= GDMA_ACCESS_FLAG_REMOTE_ATOMIC;
> > 
> > Can you enable this flag unconditionally without relation to running RW?
> 
> Yes, ATOMIC access does not depend on Remote Read and Remote Write.

The question is "do you have FW which doesn't support
GDMA_ACCESS_FLAG_REMOTE_ATOMIC? and what will happen if such flag used
for such FW?"

> I also do not see any conditions in other drivers.

At least for mlx5, we are checking FW capability if it is supported.
See get_unchangeable_access_flags().

> 
> - Konstantin
> 
> > 
> > Thanks
> > 
> > > +
> > >  	return flags;
> > >  }
> > >
> > > --
> > > 2.43.0
> > >