netdev - Re: [BUG] unbinding mv88e6xxx device spews

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250411185430.ywnlnkba4jyb7rie@skbuf>
Date: Fri, 11 Apr 2025 21:54:30 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [BUG] unbinding mv88e6xxx device spews

On Fri, Apr 11, 2025 at 07:44:00PM +0100, Russell King (Oracle) wrote:
> On Fri, Apr 11, 2025 at 09:01:59PM +0300, Vladimir Oltean wrote:
> > On Fri, Apr 11, 2025 at 06:29:52PM +0100, Russell King (Oracle) wrote:
> > > Hi,
> > > 
> > > Unbinding a mv88e6xxx device spews thusly:
> > 
> > Odd. I never saw this on the 6190 and 6390 I've been testing on, and I
> > think I know why. Could you please confirm that the attached patch fixes
> > the issue?
> 
> What else can go wrong... well, the build PC can inexplicably lose
> power just before it transfers the kernel to the TFTP server and
> modules to the target... yep, it's one of those days that if something
> can go wrong it will go wrong. I'm expecting a meteorite to destroy
> the earth in the next few minutes.
> 
> Your patch seems to fix that issue, so:
> 
> Tested-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks for testing.

> but... of course there's another issue buried beneath:
> 
> [   73.552305] WARNING: CPU: 0 PID: 398 at net/dsa/dsa.c:1486 dsa_switch_release_ports+0x114/0x118 [dsa_core]
> [   73.562504] Modules linked in: caam_jr ofpart caamhash_desc caamalg_desc reset_gpio tag_dsa crypto_engine cmdlinepart authenc libdes i2c_mux_pca954x lm75 at24 mv88e6xxx spi_nor mtd dsa_core eeprom_93xx46 caam vf610_adc error industrialio_triggered_buffer fsl_edma kfifo_buf virt_dma spi_gpio sfp spi_bitbang iio_hwmon sff mdio_mux_gpio mdio_i2c industrialio mdio_mux rpcsec_gss_krb5 auth_rpcgss
> [   73.597676] CPU: 0 UID: 0 PID: 398 Comm: bash Tainted: G        W          6.14.0+ #966
> [   73.597716] Tainted: [W]=WARN
> [   73.597724] Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
> [   73.597737] Call trace:
> [   73.597758] [<c0009c44>] (unwind_backtrace) from [<c0022b78>] (show_stack+0x10/0x14)
> [   73.597849] [<c0022b78>] (show_stack) from [<c0019b5c>] (dump_stack_lvl+0x50/0x64)
> [   73.597921] [<c0019b5c>] (dump_stack_lvl) from [<c0043cd4>] (__warn+0x80/0x128)
> [   73.597986] [<c0043cd4>] (__warn) from [<c0043ee4>] (warn_slowpath_fmt+0x168/0x16c)
> [   73.598034] [<c0043ee4>] (warn_slowpath_fmt) from [<bf0b8764>] (dsa_switch_release_ports+0x114/0x118 [dsa_core])
> [   73.598297] [<bf0b8764>] (dsa_switch_release_ports [dsa_core]) from [<bf0b929c>] (dsa_unregister_switch+0x28/0x184 [dsa_core])
> [   73.598654] [<bf0b929c>] (dsa_unregister_switch [dsa_core]) from [<bf105b30>] (mv88e6xxx_remove+0x34/0xbc [mv88e6xxx])
> [   73.599326] [<bf105b30>] (mv88e6xxx_remove [mv88e6xxx]) from [<c066f838>] (mdio_remove+0x1c/0x30)
> [   73.599577] [<c066f838>] (mdio_remove) from [<c05e15f8>] (device_release_driver_internal+0x180/0x1f4)
> [   73.599666] [<c05e15f8>] (device_release_driver_internal) from [<c05df3bc>] (unbind_store+0x54/0x90)
> [   73.599726] [<c05df3bc>] (unbind_store) from [<c02f9388>] (kernfs_fop_write_iter+0x10c/0x1cc)
> [   73.599790] [<c02f9388>] (kernfs_fop_write_iter) from [<c02608a4>] (vfs_write+0x2a4/0x3dc)
> [   73.599839] [<c02608a4>] (vfs_write) from [<c0260adc>] (ksys_write+0x50/0xac)
> [   73.599876] [<c0260adc>] (ksys_write) from [<c0008320>] (ret_fast_syscall+0x0/0x54)
> [   73.599912] Exception stack(0xe0b25fa8 to 0xe0b25ff0)
> [   73.599940] 5fa0:                   00000010 024dd820 00000001 024dd820 00000010 00000001
> [   73.599964] 5fc0: 00000010 024dd820 b6bb5d50 00000004 00000010 0055db68 00000000 00000000
> [   73.599982] 5fe0: 00000004 bea469a0 b6b4e3fb b6ac7656
> [   73.767849] ---[ end trace 0000000000000000 ]---
> bash-5.0# [   74.466821] fec 400d0000.ethernet eth0: Graceful transmit stop did not complete!
> [   74.474953] fec 400d0000.ethernet eth0: Link is Down
> 
> which seems to be due to:
> 
>                 WARN_ON(!list_empty(&dp->vlans));
> 
> This is probably due to the other issue I reported:
> 
> [   44.485597] br0: port 9(optical2) entered disabled state
> [   44.498847] br0: port 9(optical2) failed to delete vlan 1: -ENOENT
> [   44.505353] ------------[ cut here ]------------
> [   44.510052] WARNING: CPU: 0 PID: 438 at net/bridge/br_vlan.c:433 nbp_vlan_flu
> sh+0xc0/0xc4

No, they're not related. This is the third one, and I already know about it,
but it's relatively harmless.  Since I knocked down 2 already, let me
just go and take care of this one as well.