netdev - Re: [BUG] unbinding mv88e6xxx device spews

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250411191447.b3p3neasoxk5bz6e@skbuf>
Date: Fri, 11 Apr 2025 22:14:47 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [BUG] unbinding mv88e6xxx device spews

On Fri, Apr 11, 2025 at 09:54:30PM +0300, Vladimir Oltean wrote:
> > but... of course there's another issue buried beneath:
> > 
> > which seems to be due to:
> > 
> >                 WARN_ON(!list_empty(&dp->vlans));
> > 
> > This is probably due to the other issue I reported:
> > 
> > [   44.485597] br0: port 9(optical2) entered disabled state
> > [   44.498847] br0: port 9(optical2) failed to delete vlan 1: -ENOENT
> > [   44.505353] ------------[ cut here ]------------
> > [   44.510052] WARNING: CPU: 0 PID: 438 at net/bridge/br_vlan.c:433 nbp_vlan_flu
> > sh+0xc0/0xc4
> 
> No, they're not related. This is the third one, and I already know about it,
> but it's relatively harmless.  Since I knocked down 2 already, let me
> just go and take care of this one as well.

Actually, I think you're right. The WARN_ON() that &dp->vlans isn't
empty should be a consequence of the STU issue. Please let me know if
this WARN_ON() disappears when testing the patch in the other thread.

I was under the impression that you were hitting a different WARN_ON(),
just one or two lines above this one, where &dp->fdbs or &dp->mdbs are
not empty. That's what I was aware of, but it looks like you're not
there just yet.