netdev - Re: [PATCH net-next 1/2] net: ethernet: ti: am65-cpsw: set fwnode for ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGETcx8UGF3hmDgCbUaUhEjiJtwL4ay3jHa6tedV4U0hC0ioug@mail.gmail.com>
Date: Fri, 11 Apr 2025 13:17:51 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: Michael Walle <mwalle@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ethernet: ti: am65-cpsw: set fwnode for ports

On Fri, Apr 11, 2025 at 5:09 AM Michael Walle <mwalle@...nel.org> wrote:
>
> fwnode needs to be set for a device for fw_devlink to be able to
> track/enforce its dependencies correctly. Without this, you'll see error
> messages like this when the supplier has probed and tries to make sure
> all its fwnode consumers are linked to it using device links:
>
> am65-cpsw-nuss 8000000.ethernet: Failed to create device link (0x180) with supplier ..
>
> Signed-off-by: Michael Walle <mwalle@...nel.org>
> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index c9fd34787c99..af7d0f761597 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -2749,7 +2749,8 @@ am65_cpsw_nuss_init_port_ndev(struct am65_cpsw_common *common, u32 port_idx)
>         mutex_init(&ndev_priv->mm_lock);
>         port->qos.link_speed = SPEED_UNKNOWN;
>         SET_NETDEV_DEV(port->ndev, dev);
> -       port->ndev->dev.of_node = port->slave.port_np;
> +       device_set_node(&port->ndev->dev,
> +                       of_fwnode_handle(of_node_get(port->slave.port_np)));

Why are you doing of_node_get()? If that's a bug fix, can you do that
as a separate patch?

After you address that:
Reviewed-by: Saravana Kannan <saravanak@...gle.com>

-Saravana

>
>         eth_hw_addr_set(port->ndev, port->slave.mac_addr);
>
> --
> 2.39.5
>