netdev - Re: [mail@...iiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB-mu-TgZ5ewRzn45Q5LrGtEKWGhrafP39enmV0DAYvTkU5mwQ@mail.gmail.com>
Date: Fri, 11 Apr 2025 22:18:36 +0200
From: AsciiWolf <mail@...iiwolf.com>
To: Michal Kubecek <mkubecek@...e.cz>
Cc: Petter Reinholdtsen <pere@...ian.org>, netdev@...r.kernel.org, 
	Robert Scheck <fedora@...ert-scheck.de>
Subject: Re: [mail@...iiwolf.com: Re: ethtool: Incorrect component type in
 AppStream metainfo causes issues and possible breakages]

Here is the proposed fix. It is validated using appstreamcli validate
and should work without issues.

--- org.kernel.software.network.ethtool.metainfo.xml_orig
2025-03-31 00:46:03.000000000 +0200
+++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
22:14:11.634355310 +0200
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
@@ -11,6 +11,7 @@
   </description>
   <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
   <provides>
+    <binary>ethtool</binary>
     <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
   </provides>
 </component>

Regards,
Daniel Rusek


pá 11. 4. 2025 v 15:50 odesílatel AsciiWolf <mail@...iiwolf.com> napsal:
>
> Sure,
>
> I will take a look at this later today.
>
> Regards,
> Daniel
>
> Dne pá 11. 4. 2025 15:47 uživatel Michal Kubecek <mkubecek@...e.cz> napsal:
>>
>> Hello,
>>
>> I got this report (and one more where you are already in Cc) but I'm not
>> familiar with the AppStream stuff at all. Can you take a look, please?
>>
>> Michal
>>
>> > Date: Fri, 11 Apr 2025 15:16:28 +0200
>> > From: AsciiWolf <mail@...iiwolf.com>
>> > To: Michal Kubecek <mkubecek@...e.cz>
>> > Subject: Re: ethtool: Incorrect component type in AppStream metainfo causes
>> >  issues and possible breakages
>> >
>> > This probably also needs to be fixed:
>> >
>> > https://freedesktop.org/software/appstream/docs/
>> > sect-Metadata-ConsoleApplication.html#tag-consoleapp-provides
>> >
>> > Regards,
>> > Daniel
>> >
>> > pá 11. 4. 2025 v 15:06 odesílatel AsciiWolf <mail@...iiwolf.com> napsal:
>> >
>> >     Hello Michal,
>> >
>> >     ethtool is user uninstallable via GUI (such as GNOME Software or KDE
>> >     Discover) since 6.14. This is not correct since it is a (in many
>> >     configurations pre-installed) system tool, not user app, and uninstalling
>> >     it can also uninstall other critical system packages.
>> >
>> >     The main problem is the "desktop" component type in AppStream metadata:
>> >
>> >     $ head org.kernel.software.network.ethtool.metainfo.xml
>> >     <?xml version="1.0" encoding="UTF-8"?>
>> >     <component type="desktop">
>> >       <id>org.kernel.software.network.ethtool</id>
>> >       <metadata_license>MIT</metadata_license>
>> >       <name>ethtool</name>
>> >       <summary>display or change Ethernet device settings</summary>
>> >       <description>
>> >         <p>ethtool can be used to query and change settings such as speed,
>> >         auto- negotiation and checksum offload on many network devices,
>> >         especially Ethernet devices.</p>
>> >
>> >     The correct component type should be "console-application".[1]
>> >
>> >     Alternative solution would be removing the whole metainfo file.
>> >
>> >     Please see our (Fedora) downstream ticket for more information:
>> >     https://bugzilla.redhat.com/show_bug.cgi?id=2359069
>> >
>> >     Regards,
>> >     Daniel Rusek
>> >
>> >     [1] https://freedesktop.org/software/appstream/docs/
>> >     sect-Metadata-ConsoleApplication.html or https://freedesktop.org/software/
>> >     appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

View attachment "org.kernel.software.network.ethtool.metainfo.xml" of type "text/xml" (665 bytes)