netdev - Re: [PATCH RESEND v2 net-next 12/14] ipv6: Defer fib6_purge_rt() in fib6_add_rt2node() to fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a319bd25-1a7b-456b-8912-281a10d32da3@redhat.com>
Date: Wed, 16 Apr 2025 15:59:53 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 12/14] ipv6: Defer fib6_purge_rt() in
 fib6_add_rt2node() to fib6_add().

On 4/14/25 8:15 PM, Kuniyuki Iwashima wrote:
> The next patch adds per-nexthop spinlock which protects nh->f6i_list.
> 
> When rt->nh is not NULL, fib6_add_rt2node() will be called under the lock.
> fib6_add_rt2node() could call fib6_purge_rt() for another route, which
> could holds another nexthop lock.
> 
> Then, deadlock could happen between two nexthops.
> 
> Let's defer fib6_purge_rt() after fib6_add_rt2node().
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Acked-by: Paolo Abeni <pabeni@...hat.com>