netdev - Re: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to ->exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504161104.LupK0AIu-lkp@intel.com>
Date: Wed, 16 Apr 2025 11:20:28 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to
 ->exit_rtnl().

Hi Kuniyuki,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/net-Drop-hold_rtnl-arg-from-ops_undo_list/20250415-102616
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250415022258.11491-4-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to ->exit_rtnl().
config: sh-randconfig-001-20250416
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build):

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504161104.LupK0AIu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ppp/ppp_generic.c: In function 'ppp_exit_rtnl_net':
   drivers/net/ppp/ppp_generic.c:1157:17: error: implicit declaration of function 'ppp_nl_dellink' [-Wimplicit-function-declaration]
    1157 |                 ppp_nl_dellink(ppp->dev, dev_to_kill);
         |                 ^~~~~~~~~~~~~~
   drivers/net/ppp/ppp_generic.c: At top level:
>> drivers/net/ppp/ppp_generic.c:1364:13: warning: conflicting types for 'ppp_nl_dellink'; have 'void(struct net_device *, struct list_head *)'
    1364 | static void ppp_nl_dellink(struct net_device *dev, struct list_head *head)
         |             ^~~~~~~~~~~~~~
   drivers/net/ppp/ppp_generic.c:1364:13: error: static declaration of 'ppp_nl_dellink' follows non-static declaration
   drivers/net/ppp/ppp_generic.c:1157:17: note: previous implicit declaration of 'ppp_nl_dellink' with type 'void(struct net_device *, struct list_head *)'
    1157 |                 ppp_nl_dellink(ppp->dev, dev_to_kill);
         |                 ^~~~~~~~~~~~~~


vim +1364 drivers/net/ppp/ppp_generic.c

96d934c70db6e1 Guillaume Nault 2016-04-28  1363  
96d934c70db6e1 Guillaume Nault 2016-04-28 @1364  static void ppp_nl_dellink(struct net_device *dev, struct list_head *head)
96d934c70db6e1 Guillaume Nault 2016-04-28  1365  {
96d934c70db6e1 Guillaume Nault 2016-04-28  1366  	unregister_netdevice_queue(dev, head);
96d934c70db6e1 Guillaume Nault 2016-04-28  1367  }
96d934c70db6e1 Guillaume Nault 2016-04-28  1368  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "reproduce" of type "text/plain" (715 bytes)

View attachment "config" of type "text/plain" (107766 bytes)