netdev - Re: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to ->exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504161141.gdJaxPRG-lkp@intel.com>
Date: Wed, 16 Apr 2025 11:31:05 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to
 ->exit_rtnl().

Hi Kuniyuki,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/net-Drop-hold_rtnl-arg-from-ops_undo_list/20250415-102616
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250415022258.11491-4-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 3/3] ppp: Split ppp_exit_net() to ->exit_rtnl().
config: i386-buildonly-randconfig-006-20250416
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build):

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504161141.gdJaxPRG-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/ppp/ppp_generic.c:1157:3: error: call to undeclared function 'ppp_nl_dellink'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1157 |                 ppp_nl_dellink(ppp->dev, dev_to_kill);
         |                 ^
   drivers/net/ppp/ppp_generic.c:1364:13: error: static declaration of 'ppp_nl_dellink' follows non-static declaration
    1364 | static void ppp_nl_dellink(struct net_device *dev, struct list_head *head)
         |             ^
   drivers/net/ppp/ppp_generic.c:1157:3: note: previous implicit declaration is here
    1157 |                 ppp_nl_dellink(ppp->dev, dev_to_kill);
         |                 ^
   2 errors generated.


vim +/ppp_nl_dellink +1157 drivers/net/ppp/ppp_generic.c

  1148	
  1149	static __net_exit void ppp_exit_rtnl_net(struct net *net,
  1150						 struct list_head *dev_to_kill)
  1151	{
  1152		struct ppp_net *pn = net_generic(net, ppp_net_id);
  1153		struct ppp *ppp;
  1154		int id;
  1155	
  1156		idr_for_each_entry(&pn->units_idr, ppp, id)
> 1157			ppp_nl_dellink(ppp->dev, dev_to_kill);
  1158	}
  1159	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "reproduce" of type "text/plain" (715 bytes)

View attachment "config" of type "text/plain" (231016 bytes)