netdev - Re: [PATCH v13 13/22] cxl: define a driver interface for DPA allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504160127.9vvEhASi-lkp@intel.com>
Date: Wed, 16 Apr 2025 01:40:08 +0800
From: kernel test robot <lkp@...el.com>
To: alejandro.lucero-palau@....com, linux-cxl@...r.kernel.org,
	netdev@...r.kernel.org, dan.j.williams@...el.com,
	edward.cree@....com, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com, dave.jiang@...el.com
Cc: oe-kbuild-all@...ts.linux.dev, Alejandro Lucero <alucerop@....com>,
	Ben Cheatham <benjamin.cheatham@....com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v13 13/22] cxl: define a driver interface for DPA
 allocation

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 73c117c17b562213242f432db2ddf1bcc22f39dd]

url:    https://github.com/intel-lab-lkp/linux/commits/alejandro-lucero-palau-amd-com/cxl-add-type2-device-basic-support/20250414-233241
base:   73c117c17b562213242f432db2ddf1bcc22f39dd
patch link:    https://lore.kernel.org/r/20250414151336.3852990-14-alejandro.lucero-palau%40amd.com
patch subject: [PATCH v13 13/22] cxl: define a driver interface for DPA allocation
config: loongarch-randconfig-002-20250415
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build):

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504160127.9vvEhASi-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/cxl/core/hdm.c:728: warning: Function parameter or struct member 'mode' not described in 'cxl_request_dpa'
>> drivers/cxl/core/hdm.c:728: warning: Excess function parameter 'is_ram' description in 'cxl_request_dpa'


vim +728 drivers/cxl/core/hdm.c

   707	
   708	/**
   709	 * cxl_request_dpa - search and reserve DPA given input constraints
   710	 * @cxlmd: memdev with an endpoint port with available decoders
   711	 * @is_ram: DPA operation mode (ram vs pmem)
   712	 * @alloc: dpa size required
   713	 *
   714	 * Given that a region needs to allocate from limited HPA capacity it
   715	 * may be the case that a device has more mappable DPA capacity than
   716	 * available HPA. The expectation is that @alloc is a driver known
   717	 * value based on the device capacity but it could not be available
   718	 * due to HPA constraints.
   719	 *
   720	 * Returns a pinned cxl_decoder with at least @alloc bytes of capacity
   721	 * reserved, or an error pointer. The caller is also expected to own the
   722	 * lifetime of the memdev registration associated with the endpoint to
   723	 * pin the decoder registered as well.
   724	 */
   725	struct cxl_endpoint_decoder *cxl_request_dpa(struct cxl_memdev *cxlmd,
   726						     enum cxl_partition_mode mode,
   727						     resource_size_t alloc)
 > 728	{
   729		struct cxl_port *endpoint = cxlmd->endpoint;
   730		struct cxl_endpoint_decoder *cxled;
   731		struct device *cxled_dev;
   732		int rc;
   733	
   734		if (!IS_ALIGNED(alloc, SZ_256M))
   735			return ERR_PTR(-EINVAL);
   736	
   737		down_read(&cxl_dpa_rwsem);
   738		cxled_dev = device_find_child(&endpoint->dev, NULL, find_free_decoder);
   739		up_read(&cxl_dpa_rwsem);
   740	
   741		if (!cxled_dev)
   742			return ERR_PTR(-ENXIO);
   743	
   744		cxled = to_cxl_endpoint_decoder(cxled_dev);
   745	
   746		if (!cxled) {
   747			rc = -ENODEV;
   748			goto err;
   749		}
   750	
   751		rc = cxl_dpa_set_part(cxled, mode);
   752		if (rc)
   753			goto err;
   754	
   755		rc = cxl_dpa_alloc(cxled, alloc);
   756		if (rc)
   757			goto err;
   758	
   759		return cxled;
   760	err:
   761		put_device(cxled_dev);
   762		return ERR_PTR(rc);
   763	}
   764	EXPORT_SYMBOL_NS_GPL(cxl_request_dpa, "CXL");
   765	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "reproduce" of type "text/plain" (642 bytes)

View attachment "config" of type "text/plain" (173039 bytes)