netdev - Re: [PATCH net-next 1/5] dt-bindings: net: brcm,asp-v2.0: Add v3.0 and remove v2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea48b90d-d01c-46b2-af4d-4c7bdf340f80@broadcom.com>
Date: Thu, 17 Apr 2025 10:40:27 -0700
From: Justin Chen <justin.chen@...adcom.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: rafal@...ecki.pl, linux@...linux.org.uk, hkallweit1@...il.com,
 bcm-kernel-feedback-list@...adcom.com, opendmb@...il.com,
 conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org, pabeni@...hat.com,
 kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 andrew+netdev@...n.ch, florian.fainelli@...adcom.com
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: brcm,asp-v2.0: Add v3.0
 and remove v2.0



On 4/16/2025 10:52 PM, Krzysztof Kozlowski wrote:
> On 17/04/2025 00:48, Justin Chen wrote:
>> Add asp-v3.0 support. v3.0 is a major revision that reduces
>> the feature set for cost savings. We have a reduced amount of
>> channels and network filters.
>>
>> Remove asp-v2.0 which was only supported on one SoC that never
>> saw the light of day.
> 
> 
> That's independent commit with its own justification.
> 

Acked

>>
>> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
>> ---
>>   .../bindings/net/brcm,asp-v2.0.yaml           | 19 +++++++++----------
>>   1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> index 660e2ca42daf..21a7f70d220f 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> @@ -4,7 +4,7 @@
>>   $id: http://devicetree.org/schemas/net/brcm,asp-v2.0.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>> -title: Broadcom ASP 2.0 Ethernet controller
>> +title: Broadcom ASP Ethernet controller
>>   
>>   maintainers:
>>     - Justin Chen <justin.chen@...adcom.com>
>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>>   properties:
>>     compatible:
>>       oneOf:
>> +      - items:
>> +          - enum:
>> +              - brcm,bcm74110-asp
>> +          - const: brcm,asp-v3.0
>>         - items:
>>             - enum:
>>                 - brcm,bcm74165b0-asp
>> @@ -23,10 +27,6 @@ properties:
>>             - enum:
>>                 - brcm,bcm74165-asp
>>             - const: brcm,asp-v2.1
>> -      - items:
>> -          - enum:
>> -              - brcm,bcm72165-asp
>> -          - const: brcm,asp-v2.0
>>   
>>     "#address-cells":
>>       const: 1
>> @@ -42,8 +42,7 @@ properties:
>>       minItems: 1
>>       items:
>>         - description: RX/TX interrupt
>> -      - description: Port 0 Wake-on-LAN
>> -      - description: Port 1 Wake-on-LAN
>> +      - description: Wake-on-LAN interrupt
> 
> Why all devices now have different interrupts?
> 

With ASP 2.0 removed, all SoCs will have 2 interrupts now. I need to 
remove minItems here.

Thanks for the review,
Justin

> Best regards,
> Krzysztof