netdev - Re: [PATCH net-next 4/5] net: bcmasp: Add support for asp-v3.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84187c48-43bf-41a9-9151-05de335a172a@broadcom.com>
Date: Thu, 17 Apr 2025 11:13:45 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: rafal@...ecki.pl, linux@...linux.org.uk, hkallweit1@...il.com,
 bcm-kernel-feedback-list@...adcom.com, opendmb@...il.com,
 conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org, pabeni@...hat.com,
 kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 andrew+netdev@...n.ch
Subject: Re: [PATCH net-next 4/5] net: bcmasp: Add support for asp-v3.0

On 4/16/25 15:48, Justin Chen wrote:
> The asp-v3.0 is a major HW revision that reduced the number of
> channels and filters. The goal was to save cost by reducing the
> feature set.
> 
> Changes for asp-v3.0
> - Number of network filters were reduced.
> - Number of channels were reduced.
> - EDPKT stats were removed.
> - Fix a bug with csum offload.
> 
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> ---

[snip]

>   MODULE_DEVICE_TABLE(of, bcmasp_mdio_of_match);
> @@ -1285,6 +1310,17 @@ static int bcmasp_probe(struct platform_device *pdev)
>   	 * how many interfaces come up.
>   	 */
>   	bcmasp_core_init(priv);
> +
> +	priv->mda_filters = devm_kzalloc(dev, sizeof(*priv->mda_filters)
> +					 * priv->num_mda_filters, GFP_KERNEL);

Nit: those are candidates for devm_kcalloc().

> +	if (!priv->mda_filters)
> +		return -ENOMEM;
> +
> +	priv->net_filters = devm_kzalloc(dev, sizeof(*priv->net_filters)
> +					 * priv->num_net_filters, GFP_KERNEL);

Likewise.

-- 
Florian