netdev - RE: [PATCH net-next v2] net: stmmac: visconti: convert to set_clk_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <TY7PR01MB1481870F0BA0040379A1453EE92BC2@TY7PR01MB14818.jpnprd01.prod.outlook.com>
Date: Thu, 17 Apr 2025 01:17:43 +0000
From: <nobuhiro1.iwamatsu@...hiba.co.jp>
To: <rmk+kernel@...linux.org.uk>, <andrew@...n.ch>, <hkallweit1@...il.com>
CC: <alexandre.torgue@...s.st.com>, <andrew+netdev@...n.ch>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>
Subject: RE: [PATCH net-next v2] net: stmmac: visconti: convert to
 set_clk_tx_rate() method

> -----Original Message-----
> From: Russell King <rmk@...linux.org.uk> On Behalf Of Russell King (Oracle)
> Sent: Wednesday, April 16, 2025 6:44 PM
> To: Andrew Lunn <andrew@...n.ch>; Heiner Kallweit
> <hkallweit1@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> linux-arm-kernel@...ts.infradead.org;
> linux-stm32@...md-mailman.stormreply.com; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; netdev@...r.kernel.org; iwamatsu
> nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Paolo Abeni <pabeni@...hat.com>
> Subject: [PATCH net-next v2] net: stmmac: visconti: convert to
> set_clk_tx_rate() method
> 
> Convert visconti to use the set_clk_tx_rate() method. By doing so, the GMAC
> control register will already have been updated (unlike with the
> fix_mac_speed() method) so this code can be removed while porting to the
> set_clk_tx_rate() method.
> 
> There is also no need for the spinlock, and has never been - neither
> fix_mac_speed() nor set_clk_tx_rate() can be called by more than one thread at
> a time, so the lock does nothing useful.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
> v2: add Andrew's r-b (he doesn't mind it being preserved for simple fixes) fix
> build errors.
> 
>  .../ethernet/stmicro/stmmac/dwmac-visconti.c  | 23 +++++--------------
>  1 file changed, 6 insertions(+), 17 deletions(-)

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>

Best regards,
  Nobuhiro