netdev - Re: [PATCH RESEND v2 net-next 02/14] ipv6: Get rid of RTNL for SIOCDELRT and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c0341f-8b65-4671-891a-61f6892d6e1c@redhat.com>
Date: Thu, 17 Apr 2025 08:46:01 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
 horms@...nel.org, kuba@...nel.org, kuni1840@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 02/14] ipv6: Get rid of RTNL for
 SIOCDELRT and RTM_DELROUTE.

On 4/16/25 8:45 PM, Kuniyuki Iwashima wrote:
> From: Paolo Abeni <pabeni@...hat.com>
>> but acquiring the rcu lock after grabbing the rcu protected struct
>> is confusing. It should be good adding a comment or moving the rcu lock
>> before the lookup (and dropping the RCU lock from fib6_get_table())
> 
> There are other callers of fib6_get_table(), so I'd move rcu_read_lock()
> before it, and will look into them if we can drop it from fib6_get_table().

you could provide a RCU-lockless __fib6_get_table() variant, use it
here, and with time (outside this series) such helper usage could be
extended.

Paolo