netdev - Re: [PATCH RESEND v2 net-next 14/14] ipv6: Get rid of RTNL for SIOCADDRT and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416190451.3064-1-kuniyu@amazon.com>
Date: Wed, 16 Apr 2025 12:04:46 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <pabeni@...hat.com>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<horms@...nel.org>, <kuba@...nel.org>, <kuni1840@...il.com>,
	<kuniyu@...zon.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH RESEND v2 net-next 14/14] ipv6: Get rid of RTNL for SIOCADDRT and RTM_NEWROUTE.

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 16 Apr 2025 17:26:49 +0200
> On 4/14/25 8:15 PM, Kuniyuki Iwashima wrote:
> > @@ -5250,7 +5252,7 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
> >  		cfg->fc_encap_type = nla_get_u16(tb[RTA_ENCAP_TYPE]);
> >  
> >  		err = lwtunnel_valid_encap_type(cfg->fc_encap_type,
> > -						extack, newroute);
> > +						extack, false);
> 
> It looks every caller always pass 'false' as last argument to
> lwtunnel_valid_encap_type(), so such argument could/should be dropped
> (as a follow-up if this is too big)

Yes, it will be a follow-up.

Thanks again for reviewing!