netdev - Re: [PATCH net-next v2 12/13] tools: ynl: generate code for rt-addr and add a sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250418190431.69c10431@kmaincent-XPS-13-7390>
Date: Fri, 18 Apr 2025 19:04:31 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, jacob.e.keller@...el.com, yuyanghuang@...gle.com,
 sdf@...ichev.me, gnault@...hat.com, nicolas.dichtel@...nd.com,
 petrm@...dia.com
Subject: Re: [PATCH net-next v2 12/13] tools: ynl: generate code for rt-addr
 and add a sample

On Wed,  9 Apr 2025 18:46:57 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> YNL C can now generate code for simple classic netlink families.
> Include rt-addr in the Makefile for generation and add a sample.
> 
>   $ ./tools/net/ynl/samples/rt-addr
>               lo: 127.0.0.1
>        wlp0s20f3: 192.168.1.101
>               lo: ::
>        wlp0s20f3: fe80::6385:be6:746e:8116
>             vpn0: fe80::3597:d353:b5a7:66dd
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Donald Hunter <donald.hunter@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Hello,

This seems to broke the check-spec:

$ make -C tools/net/ynl    
...
rt-addr-user.c:62:10: error: ‘IFA_PROTO’ undeclared here (not in a function); did you mean ‘IFA_RTA’?
   62 |         [IFA_PROTO] = { .name = "proto", .type = YNL_PT_U8, },
      |          ^~~~~~~~~
      |          IFA_RTA
rt-addr-user.c:62:10: error: array index in initializer not of integer type
rt-addr-user.c:62:10: note: (near initialization for ‘rt_addr_addr_attrs_policy’)
rt-addr-user.c:62:23: warning: excess elements in array initializer
   62 |         [IFA_PROTO] = { .name = "proto", .type = YNL_PT_U8, },
      |                       ^
rt-addr-user.c:62:23: note: (near initialization for ‘rt_addr_addr_attrs_policy’)

I found it through git bisect.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com