netdev - Re: [PATCH net-next v2 12/13] tools: ynl: generate code for rt-addr and add a sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250418162951.5d6dbd8e@kernel.org>
Date: Fri, 18 Apr 2025 16:29:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, jacob.e.keller@...el.com, yuyanghuang@...gle.com,
 sdf@...ichev.me, gnault@...hat.com, nicolas.dichtel@...nd.com,
 petrm@...dia.com
Subject: Re: [PATCH net-next v2 12/13] tools: ynl: generate code for rt-addr
 and add a sample

On Fri, 18 Apr 2025 19:04:31 +0200 Kory Maincent wrote:
> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> > Reviewed-by: Donald Hunter <donald.hunter@...il.com>
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> 
> Hello,
> 
> This seems to broke the check-spec:
> 
> $ make -C tools/net/ynl    
> ...
> rt-addr-user.c:62:10: error: ‘IFA_PROTO’ undeclared here (not in a function); did you mean ‘IFA_RTA’?
>    62 |         [IFA_PROTO] = { .name = "proto", .type = YNL_PT_U8, },
>       |          ^~~~~~~~~
>       |          IFA_RTA
> rt-addr-user.c:62:10: error: array index in initializer not of integer type
> rt-addr-user.c:62:10: note: (near initialization for ‘rt_addr_addr_attrs_policy’)
> rt-addr-user.c:62:23: warning: excess elements in array initializer
>    62 |         [IFA_PROTO] = { .name = "proto", .type = YNL_PT_U8, },
>       |                       ^
> rt-addr-user.c:62:23: note: (near initialization for ‘rt_addr_addr_attrs_policy’)
> 
> I found it through git bisect.

Sorry about that. I will send a fix shortly. We needed this first:
https://lore.kernel.org/all/20250416200840.1338195-1-kuba@kernel.org/
without it YNL couldn't include if_addr.h directly.