netdev - Re: [PATCH 1/1] r8169: add module parameter aspm_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b580bd83-3c15-482e-858e-09f298c41326@gmail.com>
Date: Mon, 21 Apr 2025 10:45:58 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Crag Wang <crag0715@...il.com>
Cc: nic_swsd@...ltek.com, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 crag.wang@...l.com, dell.client.kernel@...l.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] r8169: add module parameter aspm_en_force

On 21.04.2025 10:17, Crag Wang wrote:
> 
>     Adding module parameters is discouraged.
>     Also note that you have the option already to re-activate ASPM, you can use the
>     standard PCI sysfs attributes under /sys/class/net/<if>/device/link for this.
> 
> 
> How about adding a quirk table for the matched DMI patterns, allowing the hardware
> makers to opt-in ASPM settings in the kernel segment as an alternative to the PCI sysfs?
> 
There is already such an option, see rtl_aspm_is_safe().