netdev - Re: [PATCH net-next v5 2/4] net: define an enum for the napi threaded state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250425183612.19068f23@kernel.org>
Date: Fri, 25 Apr 2025 18:36:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Samiullah Khawaja <skhawaja@...gle.com>
Cc: "David S . Miller " <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 almasrymina@...gle.com, willemb@...gle.com, jdamato@...tly.com,
 mkarsten@...terloo.ca, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 2/4] net: define an enum for the napi
 threaded state

On Thu, 24 Apr 2025 20:02:20 +0000 Samiullah Khawaja wrote:
> -			dev_set_threaded(ndev, true);
> +			dev_set_threaded(ndev, NETDEV_NAPI_THREADED_ENABLE);

The drivers having to specify the type of threading is too much.
The drivers are just indicating to the core that they are too
IRQ-constrained to reasonably handle load..

Please add a wrapper, something like dev_set_threaded_hint(netdev).
All the drivers pass true now, the second argument is already
pointless. For extra points you can export just the
dev_set_threaded_hint and make dev_set_threaded() be a core-only function.