netdev - Re: [PATCH net] bnxt_en: fix module unload sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTWM+4hry2Zf=a8eYH54icov0J73vnEDX79RDEkxd6wX2w@mail.gmail.com>
Date: Thu, 1 May 2025 03:20:58 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Vadim Fedorenko <vadfed@...a.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Michael Chan <michael.chan@...adcom.com>, 
	Pavan Chebbi <pavan.chebbi@...adcom.com>, Jakub Kicinski <kuba@...nel.org>, 
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: fix module unload sequence

On Thu, May 1, 2025 at 2:03 AM Vadim Fedorenko <vadfed@...a.com> wrote:
>
> Recent updates to the PTP part of bnxt changed the way PTP FIFO is
> cleared, skbs waiting for TX timestamps are now cleared during
> ndo_close() call. To do clearing procedure, the ptp structure must
> exist and point to a valid address. Module destroy sequence had ptp
> clear code running before netdev close causing invalid memory access and
> kernel crash. Change the sequence to destroy ptp structure after device
> close.
>
> Fixes: 8f7ae5a85137 ("bnxt_en: improve TX timestamping FIFO configuration")
> Reported-by: Taehee Yoo <ap420073@...il.com>
> Closes: https://lore.kernel.org/netdev/CAMArcTWDe2cd41=ub=zzvYifaYcYv-N-csxfqxUvejy_L0D6UQ@mail.gmail.com/
> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>

Tested-by: Taehee Yoo <ap420073@...il.com>

> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 78e496b0ec26..86a5de44b6f3 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -16006,8 +16006,8 @@ static void bnxt_remove_one(struct pci_dev *pdev)
>
>         bnxt_rdma_aux_device_del(bp);
>
> -       bnxt_ptp_clear(bp);
>         unregister_netdev(dev);
> +       bnxt_ptp_clear(bp);
>
>         bnxt_rdma_aux_device_uninit(bp);
>
> --
> 2.47.1
>