netdev - Re: [Intel-wired-lan] [PATCH iwl-next 2/2] net: intel: move RSS packet classifier types to libie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d64a6c7e-d5f8-4c7b-b896-4ecb7df4e89b@intel.com>
Date: Thu, 1 May 2025 09:52:53 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Simon Horman <horms@...nel.org>
CC: netdev <netdev@...r.kernel.org>, Anthony Nguyen
	<anthony.l.nguyen@...el.com>, Intel Wired LAN
	<intel-wired-lan@...ts.osuosl.org>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/2] net: intel: move RSS
 packet classifier types to libie



On 5/1/2025 6:51 AM, Simon Horman wrote:
> On Wed, Apr 30, 2025 at 10:11:53AM -0700, Jacob Keller wrote:
>> diff --git a/include/linux/net/intel/libie/pctype.h b/include/linux/net/intel/libie/pctype.h
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..78723c8a33a084fb1120743427273af4b982c835
>> --- /dev/null
>> +++ b/include/linux/net/intel/libie/pctype.h
>> @@ -0,0 +1,44 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/* Copyright (C) 2025 Intel Corporation */
>> +
>> +#ifndef __LIBIE_PCTYPE_H
>> +#define __LIBIE_PCTYPE_H
>> +
>> +/**
>> + * enum libie_filter_pctype - Packet Classifier Types for filters
>> + *
>> + * Packet Classifier Type indexes, used to set the xxQF_HENA registers. Also
>> + * communicated over the virtchnl API as part of struct virtchnl_rss_hashena.
>> + */
> 
> As there is a Kernel doc for this enum,
> ./tools/kernel-doc -none would like each value documented too.
> 

Hmm.. This might be a case where it makes more sense to drop the kernel
doc comment.. I feel like any thing I write here for each enum value
would just be noisy and repetitive without added value...

>> +enum libie_filter_pctype {
>> +	/* Note: Values 0-28 are reserved for future use.
>> +	 * Value 29, 30, 32 are not supported on XL710 and X710.
>> +	 */
>> +	LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP	= 29,
>> +	LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP	= 30,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV4_UDP		= 31,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK	= 32,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP		= 33,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV4_SCTP		= 34,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV4_OTHER		= 35,
>> +	LIBIE_FILTER_PCTYPE_FRAG_IPV4			= 36,
>> +	/* Note: Values 37-38 are reserved for future use.
>> +	 * Value 39, 40, 42 are not supported on XL710 and X710.
>> +	 */
>> +	LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP	= 39,
>> +	LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP	= 40,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV6_UDP		= 41,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK	= 42,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP		= 43,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV6_SCTP		= 44,
>> +	LIBIE_FILTER_PCTYPE_NONF_IPV6_OTHER		= 45,
>> +	LIBIE_FILTER_PCTYPE_FRAG_IPV6			= 46,
>> +	/* Note: Value 47 is reserved for future use */
>> +	LIBIE_FILTER_PCTYPE_FCOE_OX			= 48,
>> +	LIBIE_FILTER_PCTYPE_FCOE_RX			= 49,
>> +	LIBIE_FILTER_PCTYPE_FCOE_OTHER			= 50,
>> +	/* Note: Values 51-62 are reserved for future use */
>> +	LIBIE_FILTER_PCTYPE_L2_PAYLOAD			= 63
>> +};
>> +
>> +#endif /* __LIBIE_PCTYPE_H */
> 
> ...