netdev - Re: [PATCH iwl-next 1/2] net: intel: rename 'hena' to 'hashcfg' for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250501135146.GZ3339421@horms.kernel.org>
Date: Thu, 1 May 2025 14:51:46 +0100
From: Simon Horman <horms@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: netdev <netdev@...r.kernel.org>,
	Anthony Nguyen <anthony.l.nguyen@...el.com>,
	Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>,
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next 1/2] net: intel: rename 'hena' to 'hashcfg' for
 clarity

On Wed, Apr 30, 2025 at 10:11:52AM -0700, Jacob Keller wrote:
> i40e, ice, and iAVF all use 'hena' as a shorthand for the "hash enable"
> configuration. This comes originally from the X710 datasheet 'xxQF_HENA'
> registers. In the context of the registers the meaning is fairly clear.
> 
> However, on its own, hena is a weird name that can be more difficult to
> understand. This is especially true in ice. The E810 hardware doesn't even
> have registers with HENA in the name.
> 
> Replace the shorthand 'hena' with 'hashcfg'. This makes it clear the
> variables deal with the Hash configuration, not just a single boolean
> on/off for all hashing.
> 
> Do not update the register names. These come directly from the datasheet
> for X710 and X722, and it is more important that the names can be searched.
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>