netdev - Re: [PATCH net 1/3] selftests: drv: net: fix test failure on ipv6 sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f944c15-5f61-403f-95cd-540fa9c0b783@davidwei.uk>
Date: Fri, 2 May 2025 21:49:46 -0700
From: David Wei <dw@...idwei.uk>
To: Mohsin Bashir <mohsin.bashr@...il.com>, netdev@...r.kernel.org
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 ap420073@...il.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 1/3] selftests: drv: net: fix test failure on ipv6 sys

On 5/2/25 18:35, Mohsin Bashir wrote:
> The `get_interface_info` call has ip version hard-coded which leads to
> failures on an IPV6 system. The NetDrvEnv class already gathers
> information about remote interface, so instead of fixing the local
> implementation switch to using cfg.remote_ifname.
> 
> Before:
> ./drivers/net/ping.py
> Traceback (most recent call last):
>    File "/new_tests/./drivers/net/ping.py", line 217, in <module>
>      main()
>    File "/new_tests/./drivers/net/ping.py", line 204, in main
>      get_interface_info(cfg)
>    File "/new_tests/./drivers/net/ping.py", line 128, in get_interface_info
>      raise KsftFailEx('Can not get remote interface')
> net.lib.py.ksft.KsftFailEx: Can not get remote interface
> 
> After:
> ./drivers/net/ping.py
> TAP version 13
> 1..6
> ok 1 ping.test_default # SKIP Test requires IPv4 connectivity
> ok 2 ping.test_xdp_generic_sb # SKIP Test requires IPv4 connectivity
> ok 3 ping.test_xdp_generic_mb # SKIP Test requires IPv4 connectivity
> ok 4 ping.test_xdp_native_sb # SKIP Test requires IPv4 connectivity
> ok 5 ping.test_xdp_native_mb # SKIP Test requires IPv4 connectivity
> ok 6 ping.test_xdp_offload # SKIP device does not support offloaded XDP
> Totals: pass:0 fail:0 xfail:0 xpass:0 skip:6 error:0
> 
> Fixes: 75cc19c8ff89 ("selftests: drv-net: add xdp cases for ping.py")
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>

Unrelated to this patch, but there is an ip() helper already. Can it be
used instead of cmd() with shell=True?

Reviewed-by: David Wei <dw@...idwei.uk>