netdev - Re: [PATCH net 2/3] selftests: drv: net: avoid skipping tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db1b7f0-028c-44e9-bf98-81468dee32f0@davidwei.uk>
Date: Fri, 2 May 2025 21:54:11 -0700
From: David Wei <dw@...idwei.uk>
To: Mohsin Bashir <mohsin.bashr@...il.com>, netdev@...r.kernel.org
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 ap420073@...il.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 2/3] selftests: drv: net: avoid skipping tests

On 5/2/25 18:35, Mohsin Bashir wrote:
> On a system with either of the ipv4 or ipv6 information missing, tests
> are currently skipped. Ideally, the test should run as long as at least
> one address family is present. This patch make test run whenever
> possible.
> 
> Before:
> ./drivers/net/ping.py
> TAP version 13
> 1..6
> ok 1 ping.test_default # SKIP Test requires IPv4 connectivity
> ok 2 ping.test_xdp_generic_sb # SKIP Test requires IPv4 connectivity
> ok 3 ping.test_xdp_generic_mb # SKIP Test requires IPv4 connectivity
> ok 4 ping.test_xdp_native_sb # SKIP Test requires IPv4 connectivity
> ok 5 ping.test_xdp_native_mb # SKIP Test requires IPv4 connectivity
> ok 6 ping.test_xdp_offload # SKIP device does not support offloaded XDP
> Totals: pass:0 fail:0 xfail:0 xpass:0 skip:6 error:0
> 
> After:
> ./drivers/net/ping.py
> TAP version 13
> 1..6
> ok 1 ping.test_default
> ok 2 ping.test_xdp_generic_sb
> ok 3 ping.test_xdp_generic_mb
> ok 4 ping.test_xdp_native_sb
> ok 5 ping.test_xdp_native_mb
> ok 6 ping.test_xdp_offload # SKIP device does not support offloaded XDP
> Totals: pass:5 fail:0 xfail:0 xpass:0 skip:1 error:0
> 
> Fixes: 75cc19c8ff89 ("selftests: drv-net: add xdp cases for ping.py")
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ---
>   tools/testing/selftests/drivers/net/ping.py | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/ping.py b/tools/testing/selftests/drivers/net/ping.py
> index 5272e8b3536d..16b7d3ab0fc8 100755
> --- a/tools/testing/selftests/drivers/net/ping.py
> +++ b/tools/testing/selftests/drivers/net/ping.py
> @@ -12,7 +12,8 @@ from lib.py import defer, ethtool, ip
>   no_sleep=False
>   
>   def _test_v4(cfg) -> None:
> -    cfg.require_ipver("4")
> +    if not cfg.addr_v["4"]:
> +        return

What if cfg.remote_addr_v['4'] doesn't exist?

>   
>       cmd("ping -c 1 -W0.5 " + cfg.remote_addr_v["4"])
>       cmd("ping -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
> @@ -20,7 +21,8 @@ def _test_v4(cfg) -> None:
>       cmd("ping -s 65000 -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
>   
>   def _test_v6(cfg) -> None:
> -    cfg.require_ipver("6")
> +    if not cfg.addr_v["6"]:
> +        return
>   
>       cmd("ping -c 1 -W5 " + cfg.remote_addr_v["6"])
>       cmd("ping -c 1 -W5 " + cfg.addr_v["6"], host=cfg.remote)