netdev - Re: [PATCH net 3/3] selftests: drv: net: add version indicator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8c17a58-67fe-4cba-ad4a-a1822554c459@davidwei.uk>
Date: Fri, 2 May 2025 22:02:43 -0700
From: David Wei <dw@...idwei.uk>
To: Mohsin Bashir <mohsin.bashr@...il.com>, netdev@...r.kernel.org
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 ap420073@...il.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 3/3] selftests: drv: net: add version indicator

On 5/2/25 18:35, Mohsin Bashir wrote:
> Currently, the test result does not differentiate between the cases when
> either one of the address families are configured or if both the address
> families are configured. Ideally, the result should report if a
> particular case was skipped.
> 
> ./drivers/net/ping.py
> TAP version 13
> 1..7
> ok 1 ping.test_default_v4 # SKIP Test requires IPv4 connectivity
> ok 2 ping.test_default_v6
> ok 3 ping.test_xdp_generic_sb
> ok 4 ping.test_xdp_generic_mb
> ok 5 ping.test_xdp_native_sb
> ok 6 ping.test_xdp_native_mb
> ok 7 ping.test_xdp_offload # SKIP device does not support offloaded XDP
> Totals: pass:5 fail:0 xfail:0 xpass:0 skip:2 error:0
> 
> Fixes: 75cc19c8ff89 ("selftests: drv-net: add xdp cases for ping.py")
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ---
>   tools/testing/selftests/drivers/net/ping.py | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/ping.py b/tools/testing/selftests/drivers/net/ping.py
> index 16b7d3ab0fc8..af8df2313a3b 100755
> --- a/tools/testing/selftests/drivers/net/ping.py
> +++ b/tools/testing/selftests/drivers/net/ping.py
> @@ -136,13 +136,23 @@ def set_interface_init(cfg) -> None:
>       cmd(f"ip link set dev {cfg.ifname} xdpoffload off", shell=True)
>       cmd(f"ip link set dev {cfg.remote_ifname} mtu 1500", shell=True, host=cfg.remote)
>   
> -def test_default(cfg, netnl) -> None:
> +def test_default_v4(cfg, netnl) -> None:
> +    cfg.require_ipver("4")

With this patch, is the previous patch and this hunk still needed? I
think you can drop patch 2/3 or both.