netdev - Re: [PATCH net-next v8 01/15] net: homa: define user-visible API for Homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmxNsvfdJP9QYwR+8mQesSvNpKKpMW4H8J1ELmi0i9jn5A@mail.gmail.com>
Date: Mon, 5 May 2025 10:52:30 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Andrew Lunn <andrew@...n.ch>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, edumazet@...gle.com, 
	horms@...nel.org, kuba@...nel.org
Subject: Re: [PATCH net-next v8 01/15] net: homa: define user-visible API for Homa

On Mon, May 5, 2025 at 9:48 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > > > +int     homa_send(int sockfd, const void *message_buf,
> > > > +               size_t length, const struct sockaddr *dest_addr,
> > > > +               __u32 addrlen,  __u64 *id, __u64 completion_cookie,
> > > > +               int flags);
> > > > +int     homa_sendv(int sockfd, const struct iovec *iov,
> > > > +                int iovcnt, const struct sockaddr *dest_addr,
> > > > +                __u32 addrlen,  __u64 *id, __u64 completion_cookie,
> > > > +                int flags);
> > > > +ssize_t homa_reply(int sockfd, const void *message_buf,
> > > > +                size_t length, const struct sockaddr *dest_addr,
> > > > +                __u32 addrlen,  __u64 id);
> > > > +ssize_t homa_replyv(int sockfd, const struct iovec *iov,
> > > > +                 int iovcnt, const struct sockaddr *dest_addr,
> > > > +                 __u32 addrlen,  __u64 id);
> > >
> > > I assume the above are user-space functions definition ??? If so, they
> > > don't belong here.
> >
> > Yes, these are declarations for user-space functions that wrap the
> > sendmsg and recvmsg kernel calls. If not here, where should they go?
> > Are you suggesting a second header file (suggestions for what it
> > should be called?)? These are very thin wrappers, which I expect
> > people will almost always use instead of invoking raw sendmsg and
> > recvmsg, so I thought it would be cleanest to put them here, next to
> > other info related to the Homa kernel calls.
>
> Maybe put the whole library into tools/lib/homa.

After thinking about this some more, I think I'm going to just delete
these functions. They don't add much value and they create some
awkwardness (e.g. there would need to be a new user-level library with
their code).

-John-