netdev - Re: [PATCH net-next v8 01/15] net: homa: define user-visible API for Homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmx8xGAn8GWNFZ6bw7z_5nCnzCLRHAhjaWM6W_Z91pNvzg@mail.gmail.com>
Date: Mon, 5 May 2025 15:53:05 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, horms@...nel.org, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v8 01/15] net: homa: define user-visible API for Homa

On Mon, May 5, 2025 at 1:03 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 5/3/25 1:37 AM, John Ousterhout wrote:
> > +/* Flag bits for homa_sendmsg_args.flags (see man page for documentation):
> > + */
> > +#define HOMA_SENDMSG_PRIVATE       0x01
> > +#define HOMA_SENDMSG_NONBLOCKING   0x02
>
> It's unclear why you need to define a new mechanism instead of using
> MSG_DONTWAIT. This is possibly not needed and deserves at least a good
> motivation in the patch introducing it.

I'm not sure why that flag still exists (or HOMA_RECVMSG_NONBLOCKING
either), since Homa supports MSG_DONTWAIT and that seems to provide
the same functionality. Maybe these are leftover from earlier Homa
versions that weren't layered on sendmsg and recvmsg.

I have removed both HOMA_SENDMSG_NONBLOCKING and HOMA_RECVMSG_NONBLOCKING.

-John-