netdev - Re: [PATCH net-next v8 07/15] net: homa: create homa_interest.h and homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39fd697c-bff1-4d09-8979-c2a43a749c25@redhat.com>
Date: Tue, 6 May 2025 15:53:47 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: John Ousterhout <ouster@...stanford.edu>, netdev@...r.kernel.org
Cc: edumazet@...gle.com, horms@...nel.org, kuba@...nel.org
Subject: Re: [PATCH net-next v8 07/15] net: homa: create homa_interest.h and
 homa_interest.

On 5/3/25 1:37 AM, John Ousterhout wrote:
> +/**
> + * homa_interest_init_shared() - Initialize an interest and queue it up on a socket.

What is an 'interest'? An event like input avail or unblocking output
possible? If so, 'event' could be a possible/more idiomatic name.

> + * @interest:  Interest to initialize
> + * @hsk:       Socket on which the interests should be queued. Must be locked
> + *             by caller.
> + */
> +void homa_interest_init_shared(struct homa_interest *interest,
> +			       struct homa_sock *hsk)
> +	__must_hold(&hsk->lock)
> +{
> +	interest->rpc = NULL;
> +	atomic_set(&interest->ready, 0);
> +	interest->core = raw_smp_processor_id();

I don't see this 'core' field used later on in this series. If so,
please avoid introducing it until it's really used.

/P