netdev - Re: [PATCH net-next v8 08/15] net: homa: create homa_pacer.h and homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6b82986-52df-4d51-b854-a2eb5842a574@redhat.com>
Date: Tue, 6 May 2025 16:05:30 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: John Ousterhout <ouster@...stanford.edu>, netdev@...r.kernel.org
Cc: edumazet@...gle.com, horms@...nel.org, kuba@...nel.org
Subject: Re: [PATCH net-next v8 08/15] net: homa: create homa_pacer.h and
 homa_pacer.c

On 5/3/25 1:37 AM, John Ousterhout wrote:
> +	/**
> +	 * @link_mbps: The raw bandwidth of the network uplink, in
> +	 * units of 1e06 bits per second.  Set externally via sysctl.
> +	 */
> +	int link_mbps;

This is will be extremely problematic. In practice nobody will set this
correctly and in some cases the info is not even available (VM) or will
change dynamically due to policing/shaping.

I think you need to build your own estimator of the available B/W. I'm
unsure/I don't think you can re-use bql info here.

/P