netdev - Re: [PATCH net-next v2] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0a458de-44b4-4f08-b6d4-4775212c1cf0@gmail.com>
Date: Thu, 8 May 2025 15:41:39 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next v2] ethtool: Block setting of symmetric RSS when
 non-symmetric rx-flow-hash is requested

On 08/05/2025 11:30, Gal Pressman wrote:
> The conversion of uapi #defines to enum is not ideal, but as Jakub
> mentioned [1], we have precedent for that.
> 
> [1] https://lore.kernel.org/netdev/20250324073509.6571ade3@kernel.org/

Isn't the traditional solution to this kind of issue to do
#define FOO FOO
after each enumeration constant definition?
Any reason that can't be done here?
-ed