netdev - Re: [PATCH net-next v2] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250509162802.54bcfb5a@kernel.org>
Date: Fri, 9 May 2025 16:28:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org, Simon Horman
 <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>, Tariq Toukan
 <tariqt@...dia.com>
Subject: Re: [PATCH net-next v2] ethtool: Block setting of symmetric RSS
 when non-symmetric rx-flow-hash is requested

On Thu, 8 May 2025 15:41:39 +0100 Edward Cree wrote:
> On 08/05/2025 11:30, Gal Pressman wrote:
> > The conversion of uapi #defines to enum is not ideal, but as Jakub
> > mentioned [1], we have precedent for that.
> > 
> > [1] https://lore.kernel.org/netdev/20250324073509.6571ade3@kernel.org/  
> 
> Isn't the traditional solution to this kind of issue to do
> #define FOO FOO
> after each enumeration constant definition?
> Any reason that can't be done here?

I think the question is reverted. Any reason to do it here when we have
no proof that code using ifdef CONSTANT exists..
As previously mentioned there's precedent for define -> enum conversions
for BTF, and nobody complained. OTOH having each line followed by a
define is not super clean.