netdev - Re: [PATCH net-next v1 2/2] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505110414.ebTXSare-lkp@intel.com>
Date: Sun, 11 May 2025 05:06:13 +0800
From: kernel test robot <lkp@...el.com>
To: David J Wilder <wilder@...ibm.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, jv@...sburgh.net, wilder@...ibm.com,
	pradeeps@...ux.vnet.ibm.com, pradeep@...ibm.com, i.maximets@....org,
	amorenoz@...hat.com, haliu@...hat.com
Subject: Re: [PATCH net-next v1 2/2] bonding: Extend arp_ip_target format to
 allow for a list of vlan tags.

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/David-J-Wilder/bonding-Adding-struct-arp_target/20250509-023255
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250508183014.2554525-3-wilder%40us.ibm.com
patch subject: [PATCH net-next v1 2/2] bonding: Extend arp_ip_target format to allow for a list of vlan tags.
config: csky-randconfig-r123-20250510 (https://download.01.org/0day-ci/archive/20250511/202505110414.ebTXSare-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20250511/202505110414.ebTXSare-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505110414.ebTXSare-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/bonding/bond_main.c:6126:55: sparse: sparse: Using plain integer as NULL pointer

vim +6126 drivers/net/bonding/bond_main.c

  6109	
  6110	/* Convert vlan_list into struct bond_vlan_tag.
  6111	 * Inspired by bond_verify_device_path();
  6112	 */
  6113	static struct bond_vlan_tag *vlan_tags_parse(char *vlan_list, int level)
  6114	{
  6115		struct bond_vlan_tag *tags;
  6116		char *vlan;
  6117	
  6118		if (!vlan_list || strlen(vlan_list) == 0) {
  6119			tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC);
  6120			if (!tags)
  6121				return ERR_PTR(-ENOMEM);
  6122			tags[level].vlan_proto = BOND_VLAN_PROTO_NONE;
  6123			return tags;
  6124		}
  6125	
> 6126		for (vlan = strsep(&vlan_list, "/"); (vlan != 0); level++) {
  6127			tags = vlan_tags_parse(vlan_list, level + 1);
  6128			if (IS_ERR_OR_NULL(tags)) {
  6129				if (IS_ERR(tags))
  6130					return tags;
  6131				continue;
  6132			}
  6133	
  6134			tags[level].vlan_proto = __cpu_to_be16(ETH_P_8021Q);
  6135			if (kstrtou16(vlan, 0, &tags[level].vlan_id))
  6136				return ERR_PTR(-EINVAL);
  6137	
  6138			if (tags[level].vlan_id < 1 || tags[level].vlan_id > 4094) {
  6139				kfree(tags);
  6140				return ERR_PTR(-EINVAL);
  6141			}
  6142	
  6143			return tags;
  6144		}
  6145	
  6146		return NULL;
  6147	}
  6148	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki