netdev - Re: [PATCH net-next v1 0/2] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCF3CBlFg3G7LDGK@fedora>
Date: Mon, 12 May 2025 04:20:24 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: David J Wilder <wilder@...ibm.com>
Cc: netdev@...r.kernel.org, jv@...sburgh.net, pradeeps@...ux.vnet.ibm.com,
	pradeep@...ibm.com, i.maximets@....org, amorenoz@...hat.com,
	haliu@...hat.com
Subject: Re: [PATCH net-next v1 0/2] bonding: Extend arp_ip_target format to
 allow for a list of vlan tags.

Hi David,
On Thu, May 08, 2025 at 11:29:27AM -0700, David J Wilder wrote:
> This is a followup to this discussion:
>   https://www.spinics.net/lists/netdev/msg1085428.html
> 
> The current implementation of the arp monitor builds a list of vlan-tags by
> following the chain of net_devices above the bond. See: bond_verify_device_path().
> Unfortunately with some configurations this is not possible. One example is
> when an ovs switch is configured above the bond.
> 
> This change extends the "arp_ip_target" parameter format to allow for a list of
> vlan tags to be included for each arp target. This new list of tags is optional
> and may be omitted to preserve the current format and process of gathering tags.
> When provided the list of tags circumvents the process of gathering tags by
> using the supplied list. An empty list can be provided to simply skip the the
> process of gathering tags.
> 
> The purposed new format for arp_ip_target is:
> arp_ip_target=ipv4-address[vlan-tag\...],...
> 
> Examples:
> arp_ip_target=10.0.0.1,10.0.0.2 (Determine tags automatically for both targets)
> arp_ip_target=10.0.0.1[]        (Don't add any tags, don't gather tags)
> arp_ip_target=10.0.0.1[100/200] (Don't gather tags, use supplied list of tags)
> arp_ip_target=10.0.0.1,10.0.0.2[100] (add vlan 100 tag for 10.0.0.2.
>                                       Gather tags for 10.0.0.1.)

Thanks for the update. What about the IPv6 NS targets? Will you support it
or only the arp targets?

BTW, when add or update the parameter, please also update the bond documents
and iproute2 cmd.

Thanks
Hangbin
> 
> This is a work in process. I am requesting feedback on my approach.
> This patch allows the extended format only when setting arp_ip_target values with
> modules parameters.
> 
> TBD: Add support for sysfs, netlink and procfs.
> TBD: Kernel self tests.
> TBD: Documentation.
> 
> David J Wilder (2):
>   bonding: Adding struct arp_target
>   bonding: Extend arp_ip_target format to allow for a list of vlan tags.
> 
>  drivers/net/bonding/bond_main.c    | 163 ++++++++++++++++++++++++-----
>  drivers/net/bonding/bond_netlink.c |   4 +-
>  drivers/net/bonding/bond_options.c |  18 ++--
>  drivers/net/bonding/bond_procfs.c  |   4 +-
>  drivers/net/bonding/bond_sysfs.c   |   4 +-
>  include/net/bonding.h              |  15 ++-
>  6 files changed, 161 insertions(+), 47 deletions(-)
> 
> -- 
> 2.43.5
>