netdev - Re: [PATCH net-next] ice: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6984e594-b5eb-43d7-9783-fca106f79d8a@intel.com>
Date: Mon, 12 May 2025 12:06:56 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: <netdev@...r.kernel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Simon
 Horman" <horms@...nel.org>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next] ice: convert to ndo_hwtstamp_get() and
 ndo_hwtstamp_set()



On 5/12/2025 11:53 AM, Vladimir Oltean wrote:
> On Mon, May 12, 2025 at 11:38:17AM -0700, Jacob Keller wrote:
>> On 5/12/2025 9:00 AM, Vladimir Oltean wrote:
>>> New timestamping API was introduced in commit 66f7223039c0 ("net: add
>>> NDOs for configuring hardware timestamping") from kernel v6.6.
>>>
>>> It is time to convert the Intel ice driver to the new API, so that
>>> timestamping configuration can be removed from the ndo_eth_ioctl() path
>>> completely.
>>>
>>> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
>>> ---
>>
>> Acked-by: Jacob Keller <jacob.e.keller@...el.com>
>>
>> Thanks. This has been on my list of nits to cleanup but I hadn't gotten
>> around to it yet.
>>
>> I'm covering for Tony for a few days, and will queue this up on his
>> dev-queue today, so that it get get through our validation cycle.
> 
> Ok. I have 3 more Intel conversions pending (igb, ixgbe, i40e), but I've
> put a stop for today. I assume it's fine to post these to net-next and
> not to the iwl-next tree, or would you prefer otherwise?

I think we typically prefer to go through iwl-next because that lets us
run a validation test pass. I have no personal objection if the netdev
maintainers want to take these directly.

Thanks,
Jake