netdev - Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513134555.GC3339421@horms.kernel.org>
Date: Tue, 13 May 2025 14:45:55 +0100
From: Simon Horman <horms@...nel.org>
To: Lee Trager <lee@...ger.us>
Cc: Alexander Duyck <alexanderduyck@...com>,
	Jakub Kicinski <kuba@...nel.org>, kernel-team@...a.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Mohsin Bashir <mohsin.bashr@...il.com>,
	Sanman Pradhan <sanman.p211993@...il.com>,
	Su Hui <suhui@...china.com>, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support

On Mon, May 12, 2025 at 11:54:01AM -0700, Lee Trager wrote:
> Add support to update the CMRT and control firmware as well as the UEFI
> driver on fbnic using devlink dev flash.
> 
> Make sure the shutdown / quiescence paths like suspend take the devlink
> lock to prevent them from interrupting the FW flashing process.
> 
> Signed-off-by: Lee Trager <lee@...ger.us>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> V5:
> * Make sure fbnic_pldm_match_record() always returns a bool

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>