netdev - Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cc7aeff-e90d-4e95-a84d-b874fbb47d4a@redhat.com>
Date: Thu, 15 May 2025 12:58:47 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Lee Trager <lee@...ger.us>, Alexander Duyck <alexanderduyck@...com>,
 Jakub Kicinski <kuba@...nel.org>, kernel-team@...a.com,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>, Jacob Keller
 <jacob.e.keller@...el.com>, Mohsin Bashir <mohsin.bashr@...il.com>,
 Sanman Pradhan <sanman.p211993@...il.com>, Su Hui <suhui@...china.com>,
 Al Viro <viro@...iv.linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support

On 5/12/25 8:54 PM, Lee Trager wrote:
> +static int
> +fbnic_flash_start(struct fbnic_dev *fbd, struct pldmfw_component *component)
> +{
> +	struct fbnic_fw_completion *cmpl;
> +	int err;
> +
> +	cmpl = kzalloc(sizeof(*cmpl), GFP_KERNEL);
> +	if (!cmpl)
> +		return -ENOMEM;
> +
> +	fbnic_fw_init_cmpl(cmpl, FBNIC_TLV_MSG_ID_FW_START_UPGRADE_REQ);

Minor note for a possible follow-up: since completion allocation is
always followed by fbnic_fw_init_cmpl(), you could boundle the 2 in some
helper.

No need to repost for this.

/P