netdev - Re: [PATCH net-next 04/10] ovpn: don't drop skb's dst when xmitting packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fe0a11d-b66a-474c-a831-3c7694e12bf7@openvpn.net>
Date: Tue, 13 May 2025 09:54:36 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Sabrina Dubroca <sd@...asysnail.net>, Gert Doering <gert@...enie.muc.de>
Subject: Re: [PATCH net-next 04/10] ovpn: don't drop skb's dst when xmitting
 packet

On 13/05/2025 09:45, Paolo Abeni wrote:
[...]

>> +	/* when routing packets to a LAN behind a client, we rely on the
>> +	 * route entry that originally brought the packet into ovpn, so
>> +	 * don't release it
>> +	 */
>> +	dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
> 
> See commit 0287587884b15041203b3a362d485e1ab1f24445; the above should be
> 
> 	netif_keep_dst(dev);
> 
> and no need to additional comment, as the helper nails it.

Thanks! I missed it.

Regards,

> 
> Thanks,
> 
> Paolo
> 

-- 
Antonio Quartulli
OpenVPN Inc.