netdev - Re: [PATCH net-next v3 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd61d36-14a7-481f-8da8-43d501163ef1@kernel.org>
Date: Wed, 14 May 2025 14:18:25 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Siddharth Vadapalli <s-vadapalli@...com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 danishanwar@...com, srk@...com, linux-omap@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 8/9] net: ethernet: ti: am65-cpsw: add network
 flow classification support

On 13/05/2025 20:29, Jakub Kicinski wrote:
> On Tue, 13 May 2025 15:13:12 +0300 Roger Quadros wrote:
>> +	mutex_lock(&port->rxnfc_lock);
>> +	loc = am65_cpsw_policer_find_match(port, &cfg);
>> +	if (loc >= 0 && loc != fs->location) {
>> +		netdev_info(port->ndev,
>> +			    "rule already exists in location %d. not adding\n",
>> +			    loc);
>> +		mutex_unlock(&port->rxnfc_lock);
>> +		return -EINVAL;
>> +	}
>> +
>> +	/* delete exisiting rule */
>> +	if (loc >= 0) {
>> +		rule = am65_cpsw_get_rule(port, loc);
>> +		if (rule)
>> +			am65_cpsw_del_rule(port, rule);
>> +	}
>> +
>> +	rule = devm_kzalloc(port->common->dev, sizeof(*rule), GFP_KERNEL);
> 
> please don't use devm_ for objects you must support explicitly freeing

OK.

> 
>> +	if (!rule)
>> +		return -ENOMEM;
> 
> missing unlock

Ah, will fix.
> 
>> +
>> +	INIT_LIST_HEAD(&rule->list);
>> +	memcpy(&rule->cfg, &cfg, sizeof(cfg));
>> +	rule->location = fs->location;
>> +	ret = am65_cpsw_add_rule(port, rule);

And then here on error we need to kfree(rule)

>> +	mutex_unlock(&port->rxnfc_lock);

-- 
cheers,
-roger