netdev - [PATCH] mux: mmio: Fix missing CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515140555.325601-2-krzysztof.kozlowski@linaro.org>
Date: Thu, 15 May 2025 16:05:56 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Peter Rosin <peda@...ntia.se>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Andrew Davis <afd@...com>,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Samuel Holland <samuel@...lland.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

MMIO mux uses now regmap_init_mmio(), so one way or another
CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
!REGMAP_MMIO case:

  ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!

REGMAP_MMIO should be, because it is a non-visible symbol, but this
causes a circular dependency:

  error: recursive dependency detected!
  symbol IRQ_DOMAIN is selected by REGMAP
  symbol REGMAP default is visible depending on REGMAP_MMIO
  symbol REGMAP_MMIO is selected by MUX_MMIO
  symbol MUX_MMIO depends on MULTIPLEXER
  symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
  symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_DEVICE
  symbol MDIO_DEVICE is selected by PHYLIB
  symbol PHYLIB is selected by ARC_EMAC_CORE
  symbol ARC_EMAC_CORE is selected by EMAC_ROCKCHIP
  symbol EMAC_ROCKCHIP depends on OF_IRQ
  symbol OF_IRQ depends on IRQ_DOMAIN

... which we can break by changing dependency in EMAC_ROCKCHIP from
OF_IRQ to OF.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505150312.dYbBqUhG-lkp@intel.com/
Fixes: 61de83fd8256 ("mux: mmio: Do not use syscon helper to build regmap")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

---

Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Samuel Holland <samuel@...lland.org>
Cc: Arnd Bergmann <arnd@...db.de>
---
 drivers/mux/Kconfig              | 1 +
 drivers/net/ethernet/arc/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
index 80f015cf6e54..c68132e38138 100644
--- a/drivers/mux/Kconfig
+++ b/drivers/mux/Kconfig
@@ -48,6 +48,7 @@ config MUX_GPIO
 config MUX_MMIO
 	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
 	depends on OF
+	select REGMAP_MMIO
 	help
 	  MMIO/Regmap register bitfield-controlled Multiplexer controller.
 
diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig
index 0d400a7d8d91..8ccedece5339 100644
--- a/drivers/net/ethernet/arc/Kconfig
+++ b/drivers/net/ethernet/arc/Kconfig
@@ -26,7 +26,7 @@ config ARC_EMAC_CORE
 config EMAC_ROCKCHIP
 	tristate "Rockchip EMAC support"
 	select ARC_EMAC_CORE
-	depends on OF_IRQ && REGULATOR
+	depends on OF && REGULATOR
 	depends on ARCH_ROCKCHIP || COMPILE_TEST
 	help
 	  Support for Rockchip RK3036/RK3066/RK3188 EMAC ethernet controllers.
-- 
2.45.2