netdev - Re: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878caa72-df94-4530-95b8-ae827b82f2e4@linaro.org>
Date: Thu, 15 May 2025 16:14:40 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Peter Rosin <peda@...ntia.se>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Davis <afd@...com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Samuel Holland <samuel@...lland.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

On 15/05/2025 16:05, Krzysztof Kozlowski wrote:
> MMIO mux uses now regmap_init_mmio(), so one way or another
> CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
> !REGMAP_MMIO case:
> 
>   ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!
> 
> REGMAP_MMIO should be, because it is a non-visible symbol, but this
> causes a circular dependency:
> 
>   error: recursive dependency detected!
>   symbol IRQ_DOMAIN is selected by REGMAP
>   symbol REGMAP default is visible depending on REGMAP_MMIO
>   symbol REGMAP_MMIO is selected by MUX_MMIO
>   symbol MUX_MMIO depends on MULTIPLEXER
>   symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
>   symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_DEVICE
>   symbol MDIO_DEVICE is selected by PHYLIB
>   symbol PHYLIB is selected by ARC_EMAC_CORE
>   symbol ARC_EMAC_CORE is selected by EMAC_ROCKCHIP
>   symbol EMAC_ROCKCHIP depends on OF_IRQ
>   symbol OF_IRQ depends on IRQ_DOMAIN
> 
> ... which we can break by changing dependency in EMAC_ROCKCHIP from
> OF_IRQ to OF.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505150312.dYbBqUhG-lkp@intel.com/
> Fixes: 61de83fd8256 ("mux: mmio: Do not use syscon helper to build regmap")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Samuel Holland <samuel@...lland.org>
> Cc: Arnd Bergmann <arnd@...db.de>

Note for netdev folks:

If this looks correct approach, please kindly ack because:
1. The MUX Kconfig part is a fix for a patch in my tree going through
Greg's.
2. Above exposes circular dependency, thus should be fixed in the same
commit.

Best regards,
Krzysztof