netdev - Re: [PATCH net v2] octeontx2-af: Send Link events one by one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCYXwo-0CfHYGhh9@3958e7e617f8>
Date: Thu, 15 May 2025 16:35:14 +0000
From: Subbaraya Sundeep <sbhatta@...vell.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
        <gakula@...vell.com>, <hkelam@...vell.com>, <sgoutham@...vell.com>,
        <lcherian@...vell.com>, <bbhushan2@...vell.com>, <jerinj@...vell.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] octeontx2-af: Send Link events one by one

Hi Michal,

On 2025-05-14 at 08:11:32, Michal Swiatkowski (michal.swiatkowski@...ux.intel.com) wrote:
> On Wed, May 14, 2025 at 11:58:28AM +0530, Subbaraya Sundeep wrote:
> > Send link events one after another otherwise new message
> > is overwriting the message which is being processed by PF.
> > 
> > Fixes: a88e0f936ba9 ("octeontx2: Detect the mbox up or down message via register")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> > ---
> > v2:
> >  No changes. Added subject prefix net.
> > 
> >  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > index 992fa0b..ebb56eb 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > @@ -272,6 +272,8 @@ static void cgx_notify_pfs(struct cgx_link_event *event, struct rvu *rvu)
> >  
> >  		otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pfid);
> >  
> > +		otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pfid);
> > +
> >  		mutex_unlock(&rvu->mbox_lock);
> 
> Fix looks fine.
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> 
> In rvu_rep_up_notify() the same send function is called (and
> rvu_rep_up_notify() is called in do, while loop in
> rvu_rep_wq_handler()). Doesn't it also need waiting for response?
> Are there a message that don't need waiting? Maybe it will be best to
> always wait for response if another call can overwrite.
> 
> Thanks
> 
Okay I will modify rvu_rep_up_notify, test and send next version along
with this.

Thanks,
Sundeep

> >  	} while (pfmap);
> >  }
> > -- 
> > 2.7.4