netdev - Re: [PATCH] net: phy: add driver for MaxLinear MxL86110 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4249b016-34c3-4afc-831a-96ba61c3ffce@lunn.ch>
Date: Thu, 15 May 2025 18:36:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Stefano Radaelli <stefano.radaelli21@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Xu Liang <lxu@...linear.com>
Subject: Re: [PATCH] net: phy: add driver for MaxLinear MxL86110 PHY

> +/* delay can be adjusted in steps of about 150ps */
> +#define MXL86110_EXT_RGMII_CFG1_RX_NO_DELAY				(0x0 << 10)
> +#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_2250PS				(0xF << 10)

If the steps are 150ps, what you actually want is
#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_1950PS				(13 << 10)

since this is the closest you can get to 2000ps.

> +#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_150PS				(0x1 << 10)

And there should not be any need for this. Delays are either 0ps or
2000ps for the different RGMII modes.

       Andrew