netdev - Re: [PATCH v3 net-next 2/9] af_unix: Don't pass struct socket to maybe_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68262d53282a_25ebe529443@willemb.c.googlers.com.notmuch>
Date: Thu, 15 May 2025 14:07:15 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Willem de Bruijn <willemb@...gle.com>
Cc: Simon Horman <horms@...nel.org>, 
 Christian Brauner <brauner@...nel.org>, 
 Kuniyuki Iwashima <kuniyu@...zon.com>, 
 Kuniyuki Iwashima <kuni1840@...il.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/9] af_unix: Don't pass struct socket to
 maybe_add_creds().

Kuniyuki Iwashima wrote:
> We will move SOCK_PASS{CRED,PIDFD,SEC} from struct socket.flags
> to struct sock for better handling with SOCK_PASSRIGHTS.
> 
> Then, we don't need to access struct socket in maybe_add_creds().
> 
> Let's pass struct sock to maybe_add_creds() and its caller
> queue_oob().
> 
> While at it, we append the unix_ prefix and fix double spaces
> around the pid assignment.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>