netdev - Re: [PATCH v3 net-next 3/9] scm: Move scm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68262d85460a2_25ebe529485@willemb.c.googlers.com.notmuch>
Date: Thu, 15 May 2025 14:08:05 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Willem de Bruijn <willemb@...gle.com>
Cc: Simon Horman <horms@...nel.org>, 
 Christian Brauner <brauner@...nel.org>, 
 Kuniyuki Iwashima <kuniyu@...zon.com>, 
 Kuniyuki Iwashima <kuni1840@...il.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 3/9] scm: Move scm_recv() from scm.h to scm.c.

Kuniyuki Iwashima wrote:
> scm_recv() has been placed in scm.h since the pre-git era for no
> particular reason (I think), which makes the file really fragile.
> 
> For example, when you move SOCK_PASSCRED from include/linux/net.h to
> enum sock_flags in include/net/sock.h, you will see weird build failure
> due to terrible dependency.
> 
> To avoid the build failure in the future, let's move scm_recv(_unix())?
> and its callees to scm.c.
> 
> Note that only scm_recv() needs to be exported for Bluetooth.
> 
> scm_send() should be moved to scm.c too, but I'll revisit later.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>