netdev - Re: [PATCH v5 7/7] fs: introduce file_getattr and file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202505181900.UGh2tVRs-lkp@intel.com>
Date: Sun, 18 May 2025 19:26:00 +0800
From: kernel test robot <lkp@...el.com>
To: Andrey Albershteyn <aalbersh@...hat.com>,
	Richard Henderson <richard.henderson@...aro.org>,
	Matt Turner <mattst88@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Michal Simek <monstr@...str.eu>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	Helge Deller <deller@....de>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Naveen N Rao <naveen@...nel.org>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Rich Felker <dalias@...c.org>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	"David S. Miller" <davem@...emloft.net>,
	Andreas Larsson <andreas@...sler.com>,
	Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr
 syscalls

Hi Andrey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 0d8d44db295ccad20052d6301ef49ff01fb8ae2d]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrey-Albershteyn/fs-split-fileattr-related-helpers-into-separate-file/20250513-172128
base:   0d8d44db295ccad20052d6301ef49ff01fb8ae2d
patch link:    https://lore.kernel.org/r/20250513-xattrat-syscall-v5-7-22bb9c6c767f%40kernel.org
patch subject: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
config: s390-randconfig-r112-20250518 (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce: (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505181900.UGh2tVRs-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
   fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
   fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
   fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
   fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer

vim +362 fs/file_attr.c

   361	
 > 362	SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename,
   363			struct fsxattr __user *, ufsx, size_t, usize,
   364			unsigned int, at_flags)
   365	{
   366		struct fileattr fa = {};
   367		struct path filepath __free(path_put) = {};
   368		int error;
   369		unsigned int lookup_flags = 0;
   370		struct filename *name;
   371		struct fsxattr fsx = {};
   372	
   373		BUILD_BUG_ON(sizeof(struct fsxattr) < FSXATTR_SIZE_VER0);
   374		BUILD_BUG_ON(sizeof(struct fsxattr) != FSXATTR_SIZE_LATEST);
   375	
   376		if ((at_flags & ~(AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH)) != 0)
   377			return -EINVAL;
   378	
   379		if (!(at_flags & AT_SYMLINK_NOFOLLOW))
   380			lookup_flags |= LOOKUP_FOLLOW;
   381	
   382		if (usize > PAGE_SIZE)
   383			return -E2BIG;
   384	
   385		if (usize < FSXATTR_SIZE_VER0)
   386			return -EINVAL;
   387	
   388		name = getname_maybe_null(filename, at_flags);
   389		if (IS_ERR(name))
   390			return PTR_ERR(name);
   391	
   392		if (!name && dfd >= 0) {
   393			CLASS(fd, f)(dfd);
   394	
   395			filepath = fd_file(f)->f_path;
   396			path_get(&filepath);
   397		} else {
   398			error = filename_lookup(dfd, name, lookup_flags, &filepath,
   399						NULL);
   400			putname(name);
   401			if (error)
   402				return error;
   403		}
   404	
   405		error = vfs_fileattr_get(filepath.dentry, &fa);
   406		if (error)
   407			return error;
   408	
   409		fileattr_to_fsxattr(&fa, &fsx);
   410		error = copy_struct_to_user(ufsx, usize, &fsx, sizeof(struct fsxattr),
   411					    NULL);
   412	
   413		return error;
   414	}
   415	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki