netdev - Re: [PATCH v5 7/7] fs: introduce file_getattr and file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250519080659.11601Ae4-hca@linux.ibm.com>
Date: Mon, 19 May 2025 10:06:59 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: kernel test robot <lkp@...el.com>
Cc: Andrey Albershteyn <aalbersh@...hat.com>,
        Richard Henderson <richard.henderson@...aro.org>,
        Matt Turner <mattst88@...il.com>, Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Michal Simek <monstr@...str.eu>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Naveen N Rao <naveen@...nel.org>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        "David S. Miller" <davem@...emloft.net>,
        Andreas Larsson <andreas@...sler.com>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>, oe-kbuild-all@...ts.linux.dev,
        netdev@...r.kernel.org
Subject: Re: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr
 syscalls

On Sun, May 18, 2025 at 07:26:00PM +0800, kernel test robot wrote:
> Hi Andrey,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on 0d8d44db295ccad20052d6301ef49ff01fb8ae2d]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Andrey-Albershteyn/fs-split-fileattr-related-helpers-into-separate-file/20250513-172128
> base:   0d8d44db295ccad20052d6301ef49ff01fb8ae2d
> patch link:    https://lore.kernel.org/r/20250513-xattrat-syscall-v5-7-22bb9c6c767f%40kernel.org
> patch subject: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
> config: s390-randconfig-r112-20250518 (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 8.5.0
> reproduce: (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505181900.UGh2tVRs-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
> >> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
> >> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
> >> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>    fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
>    fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
>    fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
>    fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
> 
> vim +362 fs/file_attr.c
> 
>    361	
>  > 362	SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename,
>    363			struct fsxattr __user *, ufsx, size_t, usize,
>    364			unsigned int, at_flags)
>    365	{

Please ignore the warning. There is nothing to fix; this is a warning which
happens only with CONFIG_COMPAT and Al's "SC_DELOUSE" macro, which is used for
compat syscalls. Sparse cannot handle that.