netdev - Re: [PATCH net-next] net: libwx: Fix log level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCrocTkoD9BoOTCm@mev-dev.igk.intel.com>
Date: Mon, 19 May 2025 10:14:41 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: 'Michal Swiatkowski' <michal.swiatkowski@...ux.intel.com>,
	netdev@...r.kernel.org, pabeni@...hat.com, kuba@...nel.org,
	edumazet@...gle.com, davem@...emloft.net, andrew+netdev@...n.ch,
	mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next] net: libwx: Fix log level

On Mon, May 19, 2025 at 03:08:15PM +0800, Jiawen Wu wrote:
> On Mon, May 19, 2025 2:56 PM, Michal Swiatkowski wrote:
> > On Mon, May 19, 2025 at 02:33:57PM +0800, Jiawen Wu wrote:
> > > There is a log should be printed as info level, not error level.
> > >
> > > Fixes: 9bfd65980f8d ("net: libwx: Add sriov api for wangxun nics")
> > > Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> > > ---
> > >  drivers/net/ethernet/wangxun/libwx/wx_sriov.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_sriov.c b/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > index 52e6a6faf715..195f64baedab 100644
> > > --- a/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > +++ b/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > @@ -76,7 +76,7 @@ static int __wx_enable_sriov(struct wx *wx, u8 num_vfs)
> > >  	u32 value = 0;
> > >
> > >  	set_bit(WX_FLAG_SRIOV_ENABLED, wx->flags);
> > > -	wx_err(wx, "SR-IOV enabled with %d VFs\n", num_vfs);
> > > +	dev_info(&wx->pdev->dev, "SR-IOV enabled with %d VFs\n", num_vfs);
> > >
> > >  	/* Enable VMDq flag so device will be set in VM mode */
> > >  	set_bit(WX_FLAG_VMDQ_ENABLED, wx->flags);
> > 
> > It is unclear if you want it to go to net, or net-next (net-next in
> > subject, but fixes tag in commit message). I think it should go to
> > net-next, so fixes tag can be dropped.
> 
> It is because the fixes tag commit is not merged in net yet, so I give it a prefix net-next.
> 
> 

Oh, sorry for not checking that.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>